Improve highlighting for numbers #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bad octals as errors (`0709`, `081`) * Hexadecimal integers starting with `OX` (`0XdeadBEEF`) * Imaginary numbers with exponents (`1E6i`, `0.5e3i`) * Negative numbers of all types
fatih
added a commit
that referenced
this pull request
Mar 13, 2016
Improve highlighting for numbers
|
This looks great. Thanks @illicium for the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before/after:
0709,081)OX(0XdeadBEEF)1E6i,0.5e3i)Periods at the beginning/end of floats seem to not be highlighted -- this is consistent with a bunch of other syntax scripts, but if anyone is a highlighting wizard and knows why, please let me know!