goinfo improvements #759
Merged
goinfo improvements #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let result = go#complete#GetInfo() | ||
| if !empty(result) | ||
| if !empty(result) && (!a:auto && result ==# "PANIC PANIC PANIC") |
There was a problem hiding this comment.
Can you please add a comment here what auto means and what Panic Panic Panic means? (I know what it is, but we have to much logic here and if someone else reads the code there is zero information)
There was a problem hiding this comment.
that if condition didn't even work properly. I updated it now.
Info() will not echo PANIC PANIC PANIC if it's called from the autocommand.
|
Thanks @nhooyr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info()will not echoPANIC PANIC PANICif it's called from theautocommand.
@peterhellberg what do you think?