Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http handler snippets #816

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Add http handler snippets #816

merged 1 commit into from
Apr 26, 2016

Conversation

andrewstuart
Copy link
Contributor

This just adds a couple simple snippets for creating http handler functions.

@fatih fatih merged commit 08a9c7c into fatih:master Apr 26, 2016
@fatih
Copy link
Owner

fatih commented Apr 26, 2016

Thanks @andrewstuart 👍

@andrewstuart
Copy link
Contributor Author

Haha, that was fast! Thanks for keeping up a great project!

@fatih
Copy link
Owner

fatih commented Apr 26, 2016

Yeap, added it to the changelog as well: https://github.com/fatih/vim-go/blob/master/CHANGELOG.md#17-unreleased

Sometimes the PR's are just simple, so I can merge without any problems. You're welcome and thanks again for the contribution :)

@brunnre8
Copy link

brunnre8 commented Jun 7, 2016

what's the reason for not prefixing the ResponseWriter and the Request with http.*?

In my view most people are using the std lib and not developing for it so I expect a handle function to be using the http package

Or am I generally missing something? (I just started learning the language, please be patient 😉)

@andrewstuart
Copy link
Contributor Author

This should have been fixed by #843 as far as I can tell, and was just an oversight on my part when I created the snippets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants