Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nnoremap <buffer> <silent> <C-w><C-]> :<C-u>call go#def#Jump(spli… #838

Merged
merged 2 commits into from
May 9, 2016
Merged

Conversation

roxma
Copy link
Contributor

@roxma roxma commented May 7, 2016

vim-go has already map the <C-]> key, and shoud also map the <C-w><C-]> key, which is opening tag in a split window in vim.

@fatih
Copy link
Owner

fatih commented May 8, 2016

Hi @roxma

This seems like a good improvement. According to the doc:

CTRL-W ]                    *CTRL-W_]* *CTRL-W_CTRL-]*
CTRL-W CTRL-]   Split current window in two.  Use identifier under cursor as a
        tag and jump to it in the new upper window.
        In Visual mode uses the Visually selected text as a tag.
        Make new window N high.

It has the shorcuts: <C-W>] and <C-W><C-]>. It seems like you only added <C-W><C-]>. Would you mind to change the code so it also covers <C-W>] ? Thanks

@roxma
Copy link
Contributor Author

roxma commented May 9, 2016

Hi @fatih
<C-W>] is added now

@fatih fatih merged commit 927e31a into fatih:master May 9, 2016
@fatih
Copy link
Owner

fatih commented May 9, 2016

Thanks @roxma 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants