style: use two spaces for all files #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had enough of dealing with various styles in our VimL files. We had a mix of tabs and spaces over all files. Some were using tabs, some were using 4 spaces. From now on the official vim-go style will be the following settings: ``` shiftwidth=2 tabstop=2 expandtab ``` The modeline for this setting is: ``` " vim: sw=2 sw=2 et ``` I've added the modeline for all files and reformatted all the files again. Some might not like the two space setting, but that's ok. The official Vim runtime files are usually like this, and the vim style guide from Google also uses two spaces for indents (no tabs). If someone wants to set a autocmd, this can be used as well: ``` autocmd BufNewFile,BufRead *.vim setlocal expandtab shiftwidth=2 tabstop=2 ```
fatih
force-pushed
the
indentations-fixes
branch
from
3953ed6
to
5a4abb5
Compare
|
To see the diff with whitespace ignored checkout: https://github.com/fatih/vim-go/pull/915/files?w=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had enough of dealing with various styles in our VimL files. We had a
mix of tabs and spaces over all files. Some were using tabs, some were
using 4 spaces.
From now on the official vim-go style will be the following settings:
The modeline for this setting is:
I've added the modeline for all files and reformatted all the files
again. Some might not like the two space setting, but that's ok. The
official Vim runtime files are usually like this, and the vim style
guide from Google also uses two spaces for indents (no tabs).
If someone wants to set a autocmd, this can be used as well: