Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Setup #26

Open
firepicaso opened this issue Sep 4, 2023 · 3 comments
Open

Initial Setup #26

firepicaso opened this issue Sep 4, 2023 · 3 comments

Comments

@firepicaso
Copy link
Collaborator

firepicaso commented Sep 4, 2023

Link to the project:
https://github.com/fatmahussein/space-travellers-hub/projects/1

We have three people in this group project.

Kindly asking for a review

@Gambit142
Copy link

Hi @firepicaso @fatmahussein @GeekyHacks 👋,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

  • Kindly attach the link to the review for the initial pull request that you made. 👍

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@Bantealem
Copy link

Hi @firepicaso , @fatmahussein and @GeekyHacks

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, the link is not your Kanban board project link. Your current link in the description is your GitHub repo link but it should be the specific kanban board link based on the project requirement.

image

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@FrederickMih
Copy link

Hi 🙋 🙋 @Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉

🎉 🍾 🎉 🍾

Highlights 🟢

  • All cards are assigned to team members 👍

Optional suggestions

N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants