Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragons #31

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Dragons #31

merged 6 commits into from
Sep 7, 2023

Conversation

firepicaso
Copy link
Collaborator

Activities of this branch

  • Added Dragons component
  • Added DranCard child component to show the dragons
  • Used spaceX API to fetch the dragons data
  • Added styling for dragons page and my dragons section in my profile page

Kindly asking for a review

@fatmahussein
Copy link
Owner

STATUS: Approved♻️

Hi @firepicaso 👋,

Good job this PR is complete and ready for merge, please make sure you don't have any conflicts with your partner's branches

Highlights 🎯

✔️ Descriptive PR
✔️ Fetching data from API 📌
✔️ Good commit history
✔️ No linter errors

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the [Code reviews limits policy](https://microverse.zendesk.com/hc/en-us/articles/1500004088561) you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using [this form](https://airtable.com/shrQAqnBwek5a0O0s).

@fatmahussein fatmahussein merged commit 48948ca into dev Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants