Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for initial values with linear equality constraints #74

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

schmoelder
Copy link
Contributor

@schmoelder schmoelder commented Nov 30, 2023

For optimization problems with linear equality constraints, initial values currently need to be specified manually. Since v1.4.0, hopsy also supports linear equality constraints. This PR integrates this new feature into CADET-Process.

Todo:

  • Add individual method to setup hopsy problem
  • Add linear equality constraints to hopsy problem
  • Remove checks
  • Add tests

@schmoelder
Copy link
Contributor Author

This PR also includes two commits (f33078b, 685fe94) from #52.

@schmoelder
Copy link
Contributor Author

schmoelder commented Nov 30, 2023

Should have tested this a bit more locally, but just wanted to get it out. This time, I will try not to force push any more until we get to cleanup phase before merging.

Copy link
Collaborator

@flo-schu flo-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I remember we implemented this. And apparently hopsy now supports equality constraints. Perfect

@schmoelder
Copy link
Contributor Author

@flo-schu do you know if we need to add more tests for this? I saw that there is already a test_linear_equality_constrained_transform so I think we're good. But just wanted to make sure.

@flo-schu
Copy link
Collaborator

Oh yes, great we have that. I think we are fine then

@schmoelder schmoelder marked this pull request as ready for review January 9, 2024 09:51
@schmoelder schmoelder changed the base branch from master to dev January 9, 2024 09:52
@schmoelder schmoelder merged commit a3f615e into dev Jan 9, 2024
5 checks passed
@schmoelder schmoelder deleted the support_lin_eq_in_hopsy branch January 9, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants