Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #266; Fixes #265; Fixes #256 #267

Merged
merged 5 commits into from
Dec 20, 2018
Merged

Fixes #266; Fixes #265; Fixes #256 #267

merged 5 commits into from
Dec 20, 2018

Conversation

cglewis
Copy link
Member

@cglewis cglewis commented Dec 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #267 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   28.65%   28.61%   -0.04%     
==========================================
  Files          23       23              
  Lines        2209     2212       +3     
==========================================
  Hits          633      633              
- Misses       1576     1579       +3
Impacted Files Coverage Δ
utils/common.py 0% <0%> (ø) ⬆️
DeviceClassifier/OneLayer/eval_OneLayer.py 21.66% <0%> (-0.19%) ⬇️
DeviceClassifier/RandomForest/eval_RandomForest.py 21.66% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4daa3...7941448. Read the comment docs.

cglewis and others added 3 commits December 20, 2018 09:18
Removed extraneous hyphen from `train_randomforest_nobuild` target
Copy link
Contributor

@lilchurro lilchurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Finished 3 clean train/eval runs without issue; merging.

@lilchurro lilchurro merged commit 9e83487 into faucetsdn:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants