Monkey patch refactoring #3919
Merged
Monkey patch refactoring #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing the monkey patching as early as possible in the application life-cycle, ensures that all uses of the classes that are monkey patched, all have the same implementation.
Now that the monkey patching has been relocated, a number of the E402 overrides are no longer necessary.
Codecov Report
@@ Coverage Diff @@
## master #3919 +/- ##
==========================================
- Coverage 92.47% 92.47% -0.00%
==========================================
Files 47 47
Lines 8876 8873 -3
==========================================
- Hits 8208 8205 -3
Misses 668 668
Continue to review full report at Codecov.
|
anarkiwi
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.