Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint: part-3 #3929

Merged
merged 7 commits into from
Aug 10, 2021
Merged

pylint: part-3 #3929

merged 7 commits into from
Aug 10, 2021

Conversation

mwutzke
Copy link
Contributor

@mwutzke mwutzke commented Aug 10, 2021

No description provided.

- W0703: Catching too general exception Exception
- I1101: Module '' has no '' member, but source is unavailable.
- W0125: Using a conditional statement with a constant value
- W0221: Number of parameters was in '' and is now in overridden '' method
- W0221: Variadics removed in overridden '' method
- R1732: Consider using 'with' for resource-allocating operations
- W0212: Access to a protected member of a client class
- C0302: Too many lines in module (/1000)
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #3929 (4c09450) into master (2e95b55) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3929   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          47       47           
  Lines        8875     8875           
=======================================
  Hits         8207     8207           
  Misses        668      668           
Impacted Files Coverage Δ
faucet/dp.py 96.50% <ø> (ø)
faucet/faucet.py 74.87% <ø> (ø)
faucet/router.py 95.24% <ø> (ø)
faucet/valve_of.py 94.47% <ø> (ø)
faucet/valve_route.py 93.52% <ø> (ø)
faucet/valve_switch_standalone.py 93.83% <ø> (ø)
faucet/valve_util.py 83.33% <0.00%> (ø)
faucet/valve.py 93.76% <100.00%> (ø)
faucet/valve_lldp.py 96.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e95b55...4c09450. Read the comment docs.

@anarkiwi anarkiwi merged commit db72142 into faucetsdn:master Aug 10, 2021
@mwutzke mwutzke deleted the pl-pt3 branch August 10, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants