Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint: part-5 #3936

Merged
merged 7 commits into from
Aug 12, 2021
Merged

pylint: part-5 #3936

merged 7 commits into from
Aug 12, 2021

Conversation

mwutzke
Copy link
Contributor

@mwutzke mwutzke commented Aug 12, 2021

No description provided.

- C0200: Consider using enumerate instead of iterating
           with range and len
- C0206: Consider iterating with .items()
- R1728: Consider using a generator instead
- R1732: Consider using 'with' for resource-allocating operations
- W0201: Attribute '' defined outside __init__
This also cleans up some shebang's and execute file permissions
for 'library' only files.
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #3936 (520578e) into master (5c8e54b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3936   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          47       47           
  Lines        8871     8871           
=======================================
  Hits         8204     8204           
  Misses        667      667           
Impacted Files Coverage Δ
faucet/valve_route.py 93.52% <ø> (ø)
faucet/conf.py 97.97% <100.00%> (ø)
faucet/dp.py 96.50% <100.00%> (ø)
faucet/stack.py 92.14% <100.00%> (ø)
faucet/vlan.py 96.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8e54b...520578e. Read the comment docs.

@anarkiwi anarkiwi merged commit aa6a454 into faucetsdn:master Aug 12, 2021
@mwutzke mwutzke deleted the pl-pt5 branch August 12, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants