Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Connection Tracking Tutorial #4132

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

courtland
Copy link

This is an attempt at introducing a connection tracking tutorial with stateful ACL rules and sNAT examples. Initially discussed in issue #4104 and via email with @gizmoguy.

The first two sections (stateful fw rules and sNAT) are complete, but the intended ICMPv6/ARP filtering section is still a TODO. I ran out of time for the time being, so I'm looking for some feedback on the tutorial thus far.

Thanks!

@gizmoguy gizmoguy self-requested a review August 7, 2022 23:08
Copy link
Member

@gizmoguy gizmoguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for this @courtland!

I have just followed all the steps and confirm the tutorial is good. There are a couple minor things to change which I've added as comments.

If you remove the ICMPv6 and ARP filtering section from this PR, I can merge this one after the minor feedback has been addressed and I'm happy to write the ICMPv6 and ARP filtering section and add it as a separate PR.

docs/tutorials/conntrack.rst Outdated Show resolved Hide resolved
docs/tutorials/conntrack.rst Show resolved Hide resolved
docs/tutorials/conntrack.rst Outdated Show resolved Hide resolved
courtland added a commit to courtland/faucet that referenced this pull request Aug 11, 2022
@courtland
Copy link
Author

Thanks for the feedback, I believe I addressed everything. Let me know if I need to squash on my end.

Copy link
Member

@gizmoguy gizmoguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Squash down to a single commit and I'll merge it. Thanks!

@courtland
Copy link
Author

Squashed. Thanks!

@gizmoguy gizmoguy merged commit b5e9fd3 into faucetsdn:master Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants