Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for OFPMatch class to OpenFlow 1.2/1.3 #12

Closed
ederlf opened this issue Apr 9, 2013 · 8 comments
Closed

Suggestion for OFPMatch class to OpenFlow 1.2/1.3 #12

ederlf opened this issue Apr 9, 2013 · 8 comments

Comments

@ederlf
Copy link
Contributor

ederlf commented Apr 9, 2013

I am implementing a simple switch for OpenFlow 1.3 and I need to retrieve the in_port value from the match fields. To do that I need to search the list for the field (as the specification doesn't require ordered fields).

My suggestion is to have a dictionary instead of a list to ease the access to the fields, using the header as the key. Something like:

in_port =  msg.match.fields[ofproto.OXM_OF_IN_PORT].value

I implemented a patch for this. If you think it's good, or have suggestions, I can submit to the developer list.

@yamahata
Copy link
Contributor

Hi. It sounds good idea.
But the discussion is done at ryu-devel mailing list.
Can you please post your discussion to the list. I'm afraid that you have to subscribe it to post mails.

@ederlf
Copy link
Contributor Author

ederlf commented Apr 10, 2013

I subscribed to the list (I'm receiving mails from this) and sent a patch today, but it did not showed on the list.

@fujita
Copy link
Contributor

fujita commented Apr 10, 2013

The mailing list is open with some filters. You can post even if you don't subscribe. You sent a plan-text mail?

@fujita fujita closed this as completed Apr 10, 2013
@ederlf
Copy link
Contributor Author

ederlf commented Apr 10, 2013

Hi Fujita.

It wasn't a plan-text. I was using the gmail default.
The delivery system replied today:

Delivery to the following recipient has been delayed:

 ryu-devel@list.sourceforge.net

Message will be retried for 2 more day(s)

Technical details of temporary failure:
The recipient server did not accept our requests to connect. Learn more at http://support.google.com/mail/bin/answer.py?answer=7720
[(0) list.sourceforge.net. [216.34.181.96]:25: Connection refused]

I will try to post using plain text. Sorry for the trouble!

@ederlf
Copy link
Contributor Author

ederlf commented Apr 12, 2013

I posted using plan-text and the result was the same. I will try to contact the sourceforge lists suppport.

@ykaneko
Copy link
Contributor

ykaneko commented Apr 12, 2013

Hello,

I suspect that the address is wrong.
the correct address is:
ryu-devel@lists.sourceforge.net

2013/4/12 Eder Leão Fernandes notifications@github.com

I posted using plan-text and the result was the same. I will try to
contact the sourceforge lists suppport.


Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-16288884
.

@ederlf
Copy link
Contributor Author

ederlf commented Apr 12, 2013

Hi,

you are right. Thanks.

I did a copy and paste from here https://github.com/osrg/ryu/blob/master/SubmittingPatches.rst
It would be good to correct the address.

@fujita
Copy link
Contributor

fujita commented Apr 12, 2013

Sorry about that. I've just sent a patch to fix it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants