Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRV-489: Added runtime env/partner info to headers #130

Conversation

vadimLF
Copy link
Contributor

@vadimLF vadimLF commented Feb 23, 2021

This PR applied new set of headers based on environment/partner information.

  • X-Runtime-Environment
    name of runtime env (ex: Netlify, Vercel, etc..) or Unknown for an environment that can't be recognizable

  • X-Runtime-Environment-OS
    Name of OS (ex: darwin, linux)

For more detailes see - DRV-489.

parkhomenko
parkhomenko previously approved these changes Feb 24, 2021
erickpintor
erickpintor previously approved these changes Feb 25, 2021
Copy link
Contributor

@erickpintor erickpintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a minor suggestion, if you want.

faunadb/client.go Outdated Show resolved Hide resolved
suggestion on getRuntimeEnvironmentOs() func

Co-authored-by: Erick Pintor <erickpintor@gmail.com>
Copy link
Contributor

@erickpintor erickpintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it.

@vadimLF vadimLF merged commit 1beb892 into fauna:master Mar 2, 2021
@vadimLF vadimLF deleted the add-runtime-environment-partner-information-to-headers branch March 2, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants