This repository has been archived by the owner on May 24, 2024. It is now read-only.
Adding browser based notifications #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 9, 2016 12:21
everything not filtered out
to set notifications on the stats page by rarity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #42 I added the notification checkboxes to the stats page, defaulting to rare and ultra rare pokemon. Notifications can be set by checking/unchecking boxes or by selecting one of the notification groups in the dropdown. Notifications will show on the desktop now, but there is a hook for a future function to support webhooks (think slack, zapier, IFTTT, etc). I will work that up next as part of #82