fix(provider): avoid static IPs such as 1.1.1.1 #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favonia
force-pushed
the
force-ip-network
branch
3 times, most recently
from
b20e8ca
to
e1cb7b9
Compare
|
|
Some ISPs are still blocking 1.1.1.1, unfortunately. The new mechanism manually resolves the host `cloudflare-dns.com` as an IPv4 or IPv6 address, skipping the dual-stack switching in the Go standard library.
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 87.84% 88.08% +0.24%
==========================================
Files 35 36 +1
Lines 2098 2166 +68
==========================================
+ Hits 1843 1908 +65
- Misses 247 249 +2
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced May 18, 2023
favonia
added a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ISPs are still blocking 1.1.1.1, unfortunately. The new mechanism manually resolves the host
cloudflare-dns.comas an IPv4 or IPv6 address, skipping the dual-stack switching in the Go standard library.