fix: Escape sequence in id selectors being ignored #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Nov 5, 2019
| @@ -67,7 +67,7 @@ export type TraversalType = | |||
| | "parent" | |||
| | "sibling"; | |||
|
|
|||
| const reName = /^(?:\\.|[\w\-\u00b0-\uFFFF])+/, | |||
| const reName = /^(?:\\([\da-f]{1,6}\s?|(\s)|.)|[\w\-\u00b0-\uFFFF])+/, | |||
There was a problem hiding this comment.
That is the regex for an escape sequence which is also used in reEscape
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selector validity is tested in https://github.com/jsdom/jsdom/blob/2d51af302581a57ee5b9b65595f1714d669b7ea2/test/web-platform-tests/to-upstream/dom/nodes/ParentNode-querySelector-escapes.html#L88
To verify
Code available in https://codesandbox.io/s/css-select-vs-elementqueryselector-o9vrw