Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manipulation): removeChildren does not correctly de-reference #1271

Closed
wants to merge 1 commit into from

Conversation

dertheodor
Copy link

When removing an element via removeElement, the references stay. This is problematic because, when the removed element is appended somewhere else, the last child of the previously removed elements parents gets also removed from the children list.
The test case shows this exact scenario.

@dertheodor
Copy link
Author

hey there @fb55, could you please review the pull request? we would be thankful if this bug could be addressed @

@fb55
Copy link
Owner

fb55 commented Apr 29, 2023

Hi @dertheodor, tests never ran on this PR. I wanted to rebase it just now to have tests run, but don't have write access to your branch. GitHub usually provides write access for maintainers of the original repo by default, please don't opt out of this if you can, it makes a maintainer's life much easer. Instead, I had to re-create this PR as #1350.

@fb55 fb55 closed this Apr 29, 2023
@fb55
Copy link
Owner

fb55 commented Apr 29, 2023

I've gone ahead and merged the re-created PR. Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants