Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blend speed up #29

Merged
merged 4 commits into from
Mar 5, 2020
Merged

Blend speed up #29

merged 4 commits into from
Mar 5, 2020

Conversation

jonathanMweiss
Copy link
Contributor

@jonathanMweiss jonathanMweiss commented Oct 9, 2019

this commit tries to address issue #12
I've reduced loop iterations while creating the coefficient matrix and b vector (by Using NumPy/Scipy operations).
This reduced the runtime on my machine from 4.5~ seconds on average to 3.6~ seconds on average.

Furthermore I've changed the function which solves the linear problem from pyamg.solve to Scipy.sparse.linalg.spsolve.

All changes together reduces runtime on average from 4.5~ to 0.5~ seconds.

All tests were done with the test() function in file poissonblending.py, time measure without saving the image.

@fbessho fbessho merged commit 6856fbb into fbessho:master Mar 5, 2020
@fbessho
Copy link
Owner

fbessho commented Mar 5, 2020

Hi @mcboomy - Thank you so much for contributing to PyPoi. The run time indeed reduced significantly on my machine too. Great job!!

@jonathanMweiss
Copy link
Contributor Author

I haven't received a notification and forgot about it. Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants