Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup EC algorithms #24

Merged
merged 5 commits into from
Jun 21, 2017
Merged

Cleanup EC algorithms #24

merged 5 commits into from
Jun 21, 2017

Conversation

fcelda
Copy link
Owner

@fcelda fcelda commented Jun 17, 2017

Some changes I propose and would like to review before merging.

  • I've unified the algorithm parameters for consistency. So it's always a bullet with:
    name - description with no other definitions
  • I've unified the steps in the algorithm so that we don't mix normal sentences with pseudocode.
  • I've added "INVALID" variant into description of algorithms' output where the function could fail.
  • I rewrote the repeat-until loop into a while loop in hash_to_curve for better readability.
  • I've cleaned up the EC ciphersuites definitions. The 2n and cofactor parameters are within the bullet specifying curve. The m parameter is determined by EC2OSP implementation, so I moved it into this bullet.
  • EC2OSP for ED25519 has m=32 not 33.

@fcelda fcelda requested review from goldbe and reyzin June 17, 2017 15:25
Copy link
Collaborator

@goldbe goldbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jan for my cref:
need to confirm that os2ecp outputs INVALID (or something like that) if conversion fails!!

Did you actually confirm this?

@goldbe goldbe merged commit c025e83 into master Jun 21, 2017
@fcelda fcelda mentioned this pull request Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants