This repository has been archived by the owner on May 8, 2024. It is now read-only.
Allow building with QT_NO_KEYWORDS #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building fcitx-qt5 with QT_NO_KEYWORDS set. Qt sets some keywords that conflict with other libraries, when building fcitx-qt5 as part of such a project. Of course, it's possible to not to passthrough it to fcitx-qt5, maybe you can consider this useful though. You can set QT_NO_KEYWORDS in target_compile_definitions in order to avoid new uses of keywords.