Fixes #161
Merged
Fixes #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch: STOR test_file1.dat 150 Using transfer connection 226 Closing transfer connection 550 Could not transfer file: denying write due to space limit The client reads the 226 response and reports no transfer error. The 550 response is read as response for the next command. After this patch: STOR test_file1.dat 150 Using transfer connection 550 Could not transfer file: denying write due to space limit This is how pure-ftpd behave
Without this flag if you have an existing file with size 10 bytes and you overwrite it with a new file with size 5 bytes the destination file will not be truncated: it will still have 10 bytes size and the new file will be at the first 5 bytes
and check if FileList interface is supported
Closed
fclairamb
approved these changes
Jul 29, 2020
Merged
fclairamb
added a commit
that referenced
this pull request
Dec 17, 2020
* Added a test around changes brought by #161 (fixes #162) * Updated the overall file transfer logic * Ensure to close the file in every case * Add test case for failed seek * Ignore close error for reads * Add tests for partial RETR/STOR and transfer open error Co-authored-by: Nicola Murino <nicola.murino@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the commit messages for details