-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue #20 #22
Fixing issue #20 #22
Conversation
We were adding spaces in the file listing for no reason.
Using the connection time instead.
…ssue-20-file-listing-with-space
I style doubt it will change antyhing (as the LIST command seems to be a bit broken).
This first implementation might have limitations but so far it works great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2 for this change.
The CI is failing but tests are passing in the log. It looks like that there is an issue with the build.
tests/handle_dirs_test.go
Outdated
break | ||
} | ||
fileName := line[47:] | ||
//t.Logf("Line: \"%s\", File: \"%s\"", line, fileName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented line with logging could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's the cyclomatic complexity of the test that has gone too high.
$ gocyclo -over 15 .
18 tests TestDirAccess tests/handle_dirs_test.go:8:1
There are lots of tests around code quality on the build stage to make sure we keep the code clean. We should also indeed prevent from having commented-out code.
I'm going to fix that.
We were adding spaces in the file listing for no reason.