Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWD: fix double quoting #265

Merged
merged 1 commit into from
Feb 12, 2022
Merged

PWD: fix double quoting #265

merged 1 commit into from
Feb 12, 2022

Conversation

drakkan
Copy link
Collaborator

@drakkan drakkan commented Jan 13, 2022

PWD sends a 257 response as MKD and the response should follow the same
rules.

Here is an output from proftpd for confirmation

ftp> mkdir ab"s
257 "/tmp/ab""s" - Directory creata con successo
ftp> cd ab"s
250 comando CWD eseguito con successo
ftp> pwd
257 "/tmp/ab""s" è la directory corrente

Also fix log dependency

Signed-off-by: Nicola Murino nicola.murino@gmail.com

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #265 (773fb0d) into main (ff79091) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   85.66%   85.66%           
=======================================
  Files          11       11           
  Lines        1542     1542           
=======================================
  Hits         1321     1321           
  Misses        152      152           
  Partials       69       69           
Impacted Files Coverage Δ
handle_dirs.go 88.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff79091...773fb0d. Read the comment docs.

Copy link
Owner

@fclairamb fclairamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PWD sends a 257 response as MKD and the response should follow the same
rules.

Here is an output from proftpd for confirmation

ftp> mkdir ab\"s
257 "/tmp/ab""s" - Directory creata con successo
ftp> cd ab\"s
250 comando CWD eseguito con successo
ftp> pwd
257 "/tmp/ab""s" è la directory corrente

Also fix log dependency

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants