Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micro-optimization: use int8 for enums #338

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Conversation

drakkan
Copy link
Collaborator

@drakkan drakkan commented Jul 27, 2022

not sure if it's worth it

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #338 (80c40b8) into main (59dc591) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files          11       11           
  Lines        1563     1563           
=======================================
  Hits         1342     1342           
  Misses        152      152           
  Partials       69       69           
Impacted Files Coverage Δ
asciiconverter.go 94.59% <ø> (ø)
client_handler.go 86.53% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59dc591...80c40b8. Read the comment docs.

Copy link
Owner

@fclairamb fclairamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason not to do it

@fclairamb fclairamb enabled auto-merge (squash) July 29, 2022 23:29
@fclairamb fclairamb merged commit ea3d820 into fclairamb:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants