Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hardcode the gateway address as the first IP of the network range #1

Closed
zorun opened this issue Apr 18, 2015 · 0 comments
Closed

Don't hardcode the gateway address as the first IP of the network range #1

zorun opened this issue Apr 18, 2015 · 0 comments

Comments

@zorun
Copy link

zorun commented Apr 18, 2015

Currently, the code takes the assumption that the gateway is always the first IP address of the network range: https://github.com/fd/go-nat/blob/master/natpmp.go#L37

But this is not always the case, see ipfs/kubo#1090

Note that it would be better if the underlying lib found that itself: jackpal/go-nat-pmp#1
fd added a commit that referenced this issue May 8, 2015
@fd
Using github.com/jackpal/gateway to discover NAT-PMP/PCP gateways
dcaf501 
This change also removes the restriction on what IP ranges can be
used with NAT-PMP/PCP.

Fixes: #1, #2
@fd fd closed this as completed May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fd @zorun