Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name validation from codecs, match unions based on name rather than fullname #136

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

bplommer
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #136 into master will decrease coverage by 0.55%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage     100%   99.44%   -0.56%     
==========================================
  Files          15       15              
  Lines         737      726      -11     
  Branches       28       32       +4     
==========================================
- Hits          737      722      -15     
- Misses          0        4       +4
Impacted Files Coverage Δ
modules/core/src/main/scala/vulcan/AvroError.scala 93.75% <0%> (-6.25%) ⬇️
modules/core/src/main/scala/vulcan/Codec.scala 100% <100%> (ø) ⬆️
...eneric/src/main/scala/vulcan/generic/package.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c39fd4...351d265. Read the comment docs.

@vlovgr
Copy link
Contributor

vlovgr commented Jan 15, 2020

Thanks @bplommer! 👍

@vlovgr vlovgr merged commit d1921b7 into master Jan 15, 2020
@vlovgr vlovgr deleted the name_validation branch January 15, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants