Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala 3 support for core + refined #239

Merged
merged 21 commits into from
Jan 14, 2021
Merged

scala 3 support for core + refined #239

merged 21 commits into from
Jan 14, 2021

Conversation

bplommer
Copy link
Member

@bplommer bplommer commented Nov 30, 2020

Codec.deriveEnum and Codec.deriveFixed had to be made specific to scala 2, because they depend on TypeTag - I'll look into bringing them back using typename as mentioned in #238, though I do wonder whether we shouldn't move autoderivation out into a separate module anyway.

Had to disable scoverage because it doesn't support dotty, but might be able to re-enable it for scala 2

@bplommer bplommer changed the title scala 3 support scala 3 support for core module Nov 30, 2020
@vlovgr
Copy link
Contributor

vlovgr commented Dec 1, 2020

@bplommer my thinking is we could move all the Codec.derive* functions to the generic module.

@bplommer
Copy link
Member Author

bplommer commented Dec 1, 2020

@bplommer my thinking is we could move all the Codec.derive* functions to the generic module.

Sounds good. Let's initially copy/alias them there and deprecate them in core?

@vlovgr
Copy link
Contributor

vlovgr commented Dec 1, 2020

@bplommer my thinking is we could move all the Codec.derive* functions to the generic module.

Sounds good. Let's initially copy/alias them there and deprecate them in core?

Yes, let's have at least one round of deprecation before removing them in the next major release. 👍

@bplommer
Copy link
Member Author

The only thing blocking this is sbt-scoverage, which shows no signs of planning to support scala 3. Ideally we'd continue to report coverage for scala 2, but that's going to require quite a lot of refactoring of the build. What do you think about dropping it for now @vlovgr ?

@bplommer bplommer changed the title scala 3 support for core module scala 3 support for core + refined Jan 13, 2021
@bplommer bplommer marked this pull request as ready for review January 13, 2021 21:41
@bplommer
Copy link
Member Author

I'm tempted to deprecate Codec.enum in favour of Codec.enumeration to avoid the issue with enum being a keyword in scala 3 - thoughts?

@bplommer bplommer requested a review from vlovgr January 13, 2021 21:43
@vlovgr
Copy link
Contributor

vlovgr commented Jan 14, 2021

What do you think about dropping it for now @vlovgr ?
👍

I'm tempted to deprecate Codec.enum in favour of Codec.enumeration to avoid the issue with enum being a keyword in scala 3 - thoughts?

Is enum a soft or hard keyword? If it's a hard keyword, then we should definitely do this.

@bplommer
Copy link
Member Author

Is enum a soft or hard keyword? If it's a hard keyword, then we should definitely do this.

Hard. I'll make that change.

@bplommer
Copy link
Member Author

@vlovgr shall we merge this and follow up with another PR to move deriveEnum to vulcan-generic?

@vlovgr
Copy link
Contributor

vlovgr commented Jan 14, 2021

@vlovgr shall we merge this and follow up with another PR to move deriveEnum to vulcan-generic?

Sounds good to me.

@bplommer bplommer merged commit acc44e6 into master Jan 14, 2021
@bplommer bplommer deleted the scala3 branch January 14, 2021 10:05
@bplommer bplommer mentioned this pull request Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants