This repository has been archived by the owner on Jan 1, 2023. It is now read-only.
Fix AssertionError when using some playback cmds
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`!` Fixed `tj.HaltExecution` not being raised in `_as_playing_check` check `?` Refractored some code to comply with pyright's new constraints | `+` `map_in_place()` `!` Add edge cases checks with invalid audio file in `get_url_audio_album_url()` `?` Utilised more functional programming from hikari's features `+` `List` internal type with some utils methods | `~` Moved some non-specific methods from `QueueList` to here `*` internal functions with optional func will now be `None` instead of default lambda
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!Fixedtj.HaltExecutionnot being raised in_as_playing_checkcheck?Refractored some code to comply with pyright's new constraints|
+map_in_place()!Add edge cases checks with invalid audio file inget_url_audio_album_url()?Utilised more functional programming from hikari's features+Listinternal type with some utils methods|
~Moved some non-specific methods fromQueueListto here*internal functions with optional func will now beNoneinstead of default lambda