This repository has been archived by the owner on Jan 1, 2023. It is now read-only.
Use the new command mention syntax #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #42 `+` When the full cmd repr is used, slash cmds will be mentioned | `+` get_full_cmd_repr(...)` | `+` get_full_cmd_repr_from_identifier(...)` `?` Refractored some pyright ignores `#~` Major lib restructuring | `~+` `cmd` -> `compose`&`flags`&`ids.py` | `~` `errors` -> `expects.py` | `~` `extras` -> `types`&`untyped`&`vars.py` | `~` `lava` -> `utils.py` | `~/` `utils` -> `types`&`vars.py` `?` replaces some pyright ignores with `typing.cast(...)` `?` replaced some old deprecated code `*` `__init_component__(other_checks & other_hooks)` is now of type `MaybeIterable[...]` `+` commands will now have `Identifier`s | `+` `cmd.ids.CommandIdentifier` | `?~` Moved cmds impl related TODOs to `cmd.ids` | `#` Massively changed cmd composers' func sig | `*` All cmds will now be forced set metadata at `StartedEvent` `?` Fix some minor incorrect docs `+` Lots more type aliases as shorthands in `utils.types`
fdnt7
added
breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
+When the full cmd repr is used, slash cmds will be mentioned|
+get_full_cmd_repr(...)|
+get_full_cmd_repr_from_identifier(...)?Refractored some pyright ignores#~Major lib restructuring|
~+cmd->compose&flags&ids.py|
~errors->expects.py|
~extras->types&untyped&vars.py|
~lava->utils.py|
~/utils->types&vars.py?replaces some pyright ignores withtyping.cast(...)?replaced some old deprecated code*__init_component__(other_checks & other_hooks)is now of typeMaybeIterable[...]+commands will now haveIdentifiers|
+cmd.ids.CommandIdentifier|
?~Moved cmds impl related TODOs tocmd.ids|
#Massively changed cmd composers' func sig|
*All cmds will now be forced set metadata atStartedEvent?Fix some minor incorrect docs+Lots more type aliases as shorthands inutils.types