This repository has been archived by the owner on Jan 1, 2023. It is now read-only.
Restructured module imports & exports #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`*` `__init__` files will now only be for exporting vars | `/` separated everything that was originally in there to a separate file | `*` every imports will now only use top level modules with the exported vars `*` Reordered every imports by relevancy relative to the current file `+` `LyraConfig` class | `*` encapsulates config data from `config.yml` | `+` as an injected dependency | `!` fixed `misc` module tracking commands of the wrong guild `-` `music` file `*` `musicutils` -> `music` `-` removed a lot of in-function imports `*` all errors will now have `~Error` as a suffix `/` seperated `BaseLyraSignal` to be bases of `ChannelMoved` and `RequestedToSpeak`
fdnt7
added
breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*__init__files will now only be for exporting vars|
/separated everything that was originally in there to a separate file|
*every imports will now only use top level modules with the exported vars*Reordered every imports by relevancy relative to the current file+LyraConfigclass|
*encapsulates config data fromconfig.yml|
+as an injected dependency|
!fixedmiscmodule tracking commands of the wrong guild-musicfile*musicutils->music-removed a lot of in-function imports*all errors will now have~Erroras a suffix/seperatedBaseLyraSignalto be bases ofChannelMovedandRequestedToSpeak