feat: Added option for global tables for Dynamodb online #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Stahl <danstahl1138@gmail.com>
Signed-off-by: Daniel Stahl <danstahl1138@gmail.com>
Signed-off-by: Daniel Stahl <danstahl1138@gmail.com>
|
Please fix linter and DCO failing |
tmihalac
suggested changes
Jan 24, 2024
| "StreamEnabled": True, | ||
| "StreamViewType": "NEW_AND_OLD_IMAGES", | ||
| } | ||
| if self.global_table_region |
There was a problem hiding this comment.
Maybe consider reversing the condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current dynamodb online store does not support global tables. This PR adds an optional attribute to the dynamodb config. If a
global_table_regionis specified,feast applywill create a replica dynamodb table in that region.