Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop dependency on non-standard importlib libraries #4109

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

tokoko
Copy link
Collaborator

@tokoko tokoko commented Apr 17, 2024

What this PR does / why we need it:

Explicit dependency on non-standard importlib libraries (importlib-resources and importlib_metadata) is no longer required after dropping 3.8. This PR switches to use alternatives from standard library.

Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franciscojavierarceo franciscojavierarceo merged commit 2c4a347 into feast-dev:master Apr 19, 2024
21 checks passed
@tokoko tokoko deleted the drop-custom-importlib branch April 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants