-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename FileOfflineStore to DaskOfflineStore #4349
Conversation
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rename file offline store to dask Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
This PR may not have been ideal. |
It's a breaking change is users are using File store in production, right? |
No, it shouldn't be. both |
Got it, it messed with the docs UI, so we can fix that. What was the reason behind this change? I think it makes it less obvious on how to use regular Files. I had a colleague who was new to Feast that was confused about it . |
The main reason was to drive home the distinction between DataSources and OfflineStores. Despite somewhat confusing naming, DataSource in feast is the concept that controls storage, while OfflineStore only controls computation engine. Sometimes those are closely linked together, but in this case not. Having |
Yeah that makes sense. I think we probably need to update the documentation to clarify this. |
Fixes #3864