Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement timeouts #12

Closed
caelunshun opened this issue Jul 4, 2019 · 2 comments · Fixed by #149
Closed

Implement timeouts #12

caelunshun opened this issue Jul 4, 2019 · 2 comments · Fixed by #149
Labels
difficulty: some
Milestone
0.5

Comments

@caelunshun
Copy link
Member

Currently, status pings which end off at Response rather than having the client send a ping packet remain permanently registered. A timeout should be implemented to deregister these network handles after some period of inactivity.
@caelunshun
Copy link
Member Author

Also, clients need to be kicked when keepalives aren't received for some time

@caelunshun caelunshun added this to the 0.4 milestone Aug 13, 2019
@caelunshun caelunshun modified the milestones: 0.4, 0.5 Aug 20, 2019
@caelunshun
Copy link
Member Author

I'm going to delay this until the networking code is rewritten using Tokio, which will make this significantly easier to implement.

@caelunshun caelunshun mentioned this issue Oct 4, 2019
Merged
caelunshun added a commit that referenced this issue Mar 3, 2021
@caelunshun
Merge pull request #12 from PauMAVA/items
e349e4d 
ItemStack refactor

Work on this is incomplete and will be followed up by PRs in Feather once `libcraft` is transferred to the new monorepo.
caelunshun added a commit that referenced this issue Mar 3, 2021
@caelunshun
libcraft: Merge pull request #12 from PauMAVA/items
7bd8827 
ItemStack refactor

Work on this is incomplete and will be followed up by PRs in Feather once `libcraft` is transferred to the new monorepo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: some
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Implement timeouts feather-rs/feather
1 participant
@caelunshun