Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve overall architecture #2

Closed
caelunshun opened this issue Jun 30, 2019 · 0 comments · Fixed by #7
Closed

Improve overall architecture #2

caelunshun opened this issue Jun 30, 2019 · 0 comments · Fixed by #7

Comments

@caelunshun
Copy link
Member

caelunshun commented Jun 30, 2019 •
edited
Loading

The current architecture is a mess and uses RefCells and Rcs to get past the borrow checker. A design more like what is explored in https://kyren.github.io/2018/09/14/rustconf-talk.html will likely be significantly more idiomatic.
@caelunshun caelunshun mentioned this issue Jun 30, 2019
Merged
ssttevee added a commit to ssttevee/feather that referenced this issue May 25, 2020
@ssttevee
Add air to list of replaceable blocks (feather-rs#2)
237389b
caelunshun added a commit that referenced this issue Mar 3, 2021
@caelunshun
Merge pull request #2 from KnoxZZ/master
818f0ff 
Create all BlockData structs
caelunshun added a commit that referenced this issue Mar 3, 2021
@caelunshun
libcraft: Merge pull request #2 from KnoxZZ/master
29c6349 
Create all BlockData structs
caelunshun added a commit that referenced this issue Mar 3, 2021
@caelunshun
quill: Merge pull request #2 from feather-rs/block-access
99b1597 
Add block access methods to Game
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Architecture rewrite feather-rs/feather
1 participant
@caelunshun