Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tree generation #138

Closed
wants to merge 6 commits into from
Closed

[WIP] Tree generation #138

wants to merge 6 commits into from

Conversation

caelunshun
Copy link
Member

@caelunshun caelunshun commented Sep 15, 2019

  • Implement a Schematic type for storing structures and writing parts of them which overlap with a chunk to the chunk
  • Implement tree schematic generators
  • Implement a tree finisher, with tree types/density based on biomes

@caelunshun caelunshun added the category: worldgen Issue related to world generation label Sep 15, 2019
@caelunshun caelunshun mentioned this pull request Sep 15, 2019
15 tasks
@codecov
Copy link

codecov bot commented Sep 15, 2019

Codecov Report

Merging #138 into develop will decrease coverage by 0.24%.
The diff coverage is 53.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
- Coverage    60.69%   60.45%   -0.25%     
===========================================
  Files           77       82       +5     
  Lines         9208     9516     +308     
===========================================
+ Hits          5589     5753     +164     
- Misses        3619     3763     +144
Impacted Files Coverage Δ
server/src/worldgen/finishers/single.rs 86.36% <ø> (ø) ⬆️
server/src/worldgen/finishers/snow.rs 100% <ø> (ø) ⬆️
server/src/worldgen/finishers/clumped.rs 96% <ø> (ø) ⬆️
server/src/worldgen/finishers/tree/ty.rs 0% <0%> (ø)
server/src/worldgen/finishers/tree/schematic.rs 0% <0%> (ø)
server/src/worldgen/mod.rs 97.88% <100%> (-0.02%) ⬇️
server/src/worldgen/finishers/tree/mod.rs 55% <55%> (ø)
server/src/worldgen/schematic.rs 69.34% <69.34%> (ø)
server/src/worldgen/presence.rs 94.87% <94.87%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d1413...983c1dc. Read the comment docs.

@caelunshun
Copy link
Member Author

I noticed a severe performance impact from adding this, and noticed a rather peculiar cause when investigating:
Screenshot from 2019-09-14 23-18-51

bitvec is for some reason the main overhead for worldgen, which seems somewhat odd...

Base automatically changed from develop to main February 27, 2021 01:51
@ambeeeeee ambeeeeee closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: worldgen Issue related to world generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants