Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utensils icon. #629

Closed
wants to merge 4 commits into from

Conversation

lukashambsch
Copy link

Utensils icon for #552.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #629 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #629   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...40579ce. Read the comment docs.

@jletey
Copy link

jletey commented Jun 25, 2019

@lukashambsch Make sure to run npm run build! It formats the icon

@lukashambsch
Copy link
Author

@lukashambsch Make sure to run npm run build! It formats the icon

Looks like it doesn't like something about the format. I've formatted it manually.

Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up your svg like other icons. And please make sure you follow #171 .

@lukashambsch
Copy link
Author

Please clean up your svg like other icons. And please make sure you follow #171 .

@locness3 Can you please be more specific on the changes you'd like to see?

I'm not a designer & I hired someone to create the icon. They say they followed #171. With some more specific feedback, I can get them to update the icon.

Thanks!

@moeenio
Copy link

moeenio commented Jun 28, 2019

Please clean up your svg like other icons. And please make sure you follow #171 .

@locness3 Can you please be more specific on the changes you'd like to see?

I would like that you clean the svg so it is like the other icons. You can look at them to see what I mean.

@lukashambsch
Copy link
Author

Please clean up your svg like other icons. And please make sure you follow #171 .

@locness3 Can you please be more specific on the changes you'd like to see?

I would like that you clean the svg so it is like the other icons. You can look at them to see what I mean.

@locness3 Thanks! Is it better now?

@jletey
Copy link

jletey commented Jun 29, 2019

@lukashambsch Remove this line ... it is not necessary and no other icons have it

Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @johnletey said, line 2 is totally not necessary. Please remove it.

@lukashambsch
Copy link
Author

@johnletey @locness3 I removed it.

@lukashambsch
Copy link
Author

@locness3 Is there anything else I can do to get this merged?

@moeenio
Copy link

moeenio commented Jul 2, 2019

@locness3 Is there anything else I can do to get this merged?

Waiting for @colebemis's approval

@mittalyashu
Copy link
Contributor

Got an idea, @lukashambsch can you split the icon into 3 different icons

  1. Spoon
  2. Fork
  3. Spoon and fork

@mittalyashu
Copy link
Contributor

2px spacing around the icon

Icon Suggestion
Figma_cwlxbFMRng Figma_DLHKHZU0yV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants