-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utensils icon. #629
Add utensils icon. #629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
Branches 3 3
=====================================
Hits 34 34 Continue to review full report at Codecov.
|
@lukashambsch Make sure to run |
Looks like it doesn't like something about the format. I've formatted it manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up your svg like other icons. And please make sure you follow #171 .
@locness3 Can you please be more specific on the changes you'd like to see? I'm not a designer & I hired someone to create the icon. They say they followed #171. With some more specific feedback, I can get them to update the icon. Thanks! |
I would like that you clean the svg so it is like the other icons. You can look at them to see what I mean. |
@locness3 Thanks! Is it better now? |
@lukashambsch Remove this line ... it is not necessary and no other icons have it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @johnletey said, line 2 is totally not necessary. Please remove it.
@johnletey @locness3 I removed it. |
@locness3 Is there anything else I can do to get this merged? |
Waiting for @colebemis's approval |
Got an idea, @lukashambsch can you split the icon into 3 different icons
|
Utensils icon for #552.