Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add campsite icon #651

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

jletey
Copy link

@jletey jletey commented Jul 2, 2019

Closes #61

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #651 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #651   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...8565e07. Read the comment docs.

moeenio
moeenio previously approved these changes Jul 2, 2019
@mittalyashu
Copy link
Contributor

Not sure, if it will work. But here's my suggestion

Suggestion
image

@moeenio
Copy link

moeenio commented Jul 22, 2019

The current one is good.

@jletey
Copy link
Author

jletey commented Jul 22, 2019

@locness3 @mittalyashu I kind of like Yashu's suggestion ... should I change?

@moeenio
Copy link

moeenio commented Jul 22, 2019

idk

@jletey
Copy link
Author

jletey commented Jul 22, 2019

@locness3 I like @mittalyashu's version better ... I have updated the icon!

moeenio
moeenio previously approved these changes Jul 22, 2019
Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe having the two versions (your one and @mittalyashu's) ?

@jletey
Copy link
Author

jletey commented Jul 22, 2019

@locness3 Done!

moeenio
moeenio previously approved these changes Jul 22, 2019
Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe using the 2 name for yours and the one for @mittalyashu's ?

@jletey jletey changed the title Add campsite icon feat: Add campsite icon Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: Campsite
3 participants