Fix tests and dependencies

feathersjs-ecosystem · Nov 8, 2020 · c9caf2d · c9caf2d
1 parent 45c6146
commit c9caf2d
Show file tree

Hide file tree

Showing 19 changed files with 677 additions and 575 deletions.
diff --git a/lib/common/iff-else.js b/lib/common/iff-else.js
@@ -8,13 +8,13 @@ module.exports = function (processFuncArray) {
 
       // Babel 6.17.0 did not transpile something in the old version similar to this
       // const runProcessFuncArray = funcs => processFuncArray.call(this, fnArgs, funcs);
-      var that = this;
-      var runProcessFuncArray = function (funcs) {
+      const that = this;
+      const runProcessFuncArray = function (funcs) {
         return processFuncArray.call(that, fnArgs, funcs);
       };
 
       // const check = typeof predicate === 'function' ? predicate(...fnArgs) : !!predicate;
-      var check = typeof predicate === 'function' ? predicate.apply(that, fnArgs) : !!predicate;
+      const check = typeof predicate === 'function' ? predicate.apply(that, fnArgs) : !!predicate;
 
       if (!check) {
         return runProcessFuncArray(falseFuncs);

diff --git a/lib/services/calling-params.js b/lib/services/calling-params.js
@@ -10,7 +10,7 @@ const defaults = {
 };
 
 // Set app wide defaults
-function callingParamsDefaults (defaultPropNames = [], defaultNewProps) {
+function callingParamsDefaults (defaultPropNames = [], defaultNewProps = undefined) {
   if (defaultPropNames) {
     defaults.propNames = Array.isArray(defaultPropNames) ? defaultPropNames : [defaultPropNames];
   }

diff --git a/lib/services/fast-join.js b/lib/services/fast-join.js
@@ -26,7 +26,7 @@ module.exports = function fastJoin (joins1, query1) {
   };
 };
 
-function joinsForQuery ({ joins } = {}, query, context = {}) {
+function joinsForQuery ({ joins } = {}, query = undefined, context = {}) {
   const runtime = [];
 
   Object.keys(joins).forEach(outerLabel => {

diff --git a/lib/services/fgraphql.js b/lib/services/fgraphql.js
@@ -69,7 +69,8 @@ module.exports = function fgraphql (options1 = {}) {
     }
 
     options.inclAllFields = contextParams.provider
-      ? options.inclAllFieldsClient : options.inclAllFieldsServer;
+      ? options.inclAllFieldsClient
+      : options.inclAllFieldsServer;
     debug(`inclAllField ${options.inclAllFields}`);
 
     // Build content parameter passed to resolver functions.

diff --git a/lib/services/populate.js b/lib/services/populate.js
@@ -239,7 +239,8 @@ function populateAddChild (options, context, parentItem, childSchema, depth) {
         });
 
       return (childSchema.include && result)
-        ? populateItemArray(options, context, result, include, depth) : result;
+        ? populateItemArray(options, context, result, include, depth)
+        : result;
     })
     .then(items => ({ nameAs, items }));
 }

diff --git a/lib/services/stash-before.js b/lib/services/stash-before.js
@@ -16,11 +16,13 @@ module.exports = function (prop) {
       throw new errors.BadRequest('Id is required. (stashBefore)');
     }
 
-    const params = context.method === 'get' ? context.params : {
-      provider: context.params.provider,
-      authenticated: context.params.authenticated,
-      user: context.params.user
-    };
+    const params = context.method === 'get'
+      ? context.params
+      : {
+          provider: context.params.provider,
+          authenticated: context.params.authenticated,
+          user: context.params.user
+        };
 
     return context.service.get(context.id, {
       ...params,