Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate redisClient (bug fix) * Customize subscriber event #155

Closed
wants to merge 5 commits into from
Closed

Duplicate redisClient (bug fix) * Customize subscriber event #155

wants to merge 5 commits into from

Conversation

dubiousdavid
Copy link
Contributor

  • Allow for the customization of the subscriber event to use message buffers with ioredis. Could also be useful for the redis package.
  • Duplicate redisClient since we need two connections, one for publish and one for subscribe.

@dubiousdavid dubiousdavid changed the title Master Duplicate redisClient (bug fix) * Customize subscriber event Jan 21, 2021
@daffl
Copy link
Member

daffl commented Jan 23, 2021

This makes sense, thank you! Two things:

  1. Could you re-submit the PR against the latest development branch instead of master?
  2. No need to update version numbers, that will happen automatically during release

@dubiousdavid
Copy link
Contributor Author

Will do.

@dubiousdavid
Copy link
Contributor Author

New PR: #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dubiousdavid @daffl