feat(core): Add app.teardown functionality #2570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is about to shut down the application and run teardown functionalities after the http server is closed on each service.
In some cases, e.g. when we stop/restart the Node application, the connections to various databases are not closed properly and remain open until the system closes these open connections after some time.
As a counterpart to
app.listen()
there is now the methodapp.close()
which closes the http server and then calls the teardown methods of the individual services.In this way, logic for teardown can also be implemented as in the setup methods of the services.
As I even saw in PR #2510, it would even be a good idea to implement an
addTeardown
method where we can configure the logic to happen at the application level.