Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix derived feature list toMap will change the original order #1209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gglilang
Copy link

Description

When derived features also depend on some derived features, these features are in order at the same stage, but after toMap, the order will be disrupted, causing an exception to be thrown
Exception in thread "main" com.linkedin.feathr.exception.FeathrException: [FEATHR_ERROR] Error when processing derived feature feature1. Requires following features to be generated [base_feature1], but found [base_feature2, base_feature3]

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@xiaoyongzhu xiaoyongzhu added the safe to test Tag to execute build pipeline for a PR from forked repo label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants