-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support KataGo (#541) and its score estimation #542
Conversation
kaorahi
commented
Jun 21, 2019
- Accept KataGo without the version cheat "-override-version 0.17"
- Show the estimated score above the winrate bar
Thanks. Can you let it use KataGo without a cmdline argument? I want it to
be very easy to setup.
…On Sat, Jun 22, 2019, 8:35 AM kaorahi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/java/featurecat/lizzie/Config.java
<#542 (comment)>:
> @@ -34,6 +34,7 @@
public boolean showCoordinates = false;
public boolean colorByWinrateInsteadOfVisits = false;
public boolean showLcbWinrate = false;
+ public boolean isKataGo = false;
It is detected dynamically from the GTP response to "name" command just
before the version check. Do we need more?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#542?email_source=notifications&email_token=ACQHLMXCQTUX2ZJJ66AWST3P3YMCBA5CNFSM4H2RGFX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4K6QEI#discussion_r296444570>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACQHLMREXLKR2Q2VAT6QUYLP3YMCBANCNFSM4H2RGFXQ>
.
|
You only need to modify two lines in config.txt to use KataGo. No cmdline argument is required. Lizzie detects KataGo automatically through GTP.
|
I tried to compile with this change, and used @alreadydone 's windows compilation of KataGo (lightvector/KataGo#2) I had an issue that lizzie would still use lz-analyze. I suspect that it is because it takes quite some time for the engine to load, and therefore respond with the proper 'name'. I'm not too sure as I'm a bit inexperienced will all this. I just made some manual changes to force it to use kata-analyze and draw the score difference no matter what.. |
Anyway, we may have another better implementation soon :) |
I tried again with the new changes, and now I get it to start with kata-analyze |
LGTM. Maybe it will be merged together #546 . |