Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KataGo (#541) and its score estimation #542

Merged
merged 8 commits into from
Jun 28, 2019

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Jun 21, 2019

  • Accept KataGo without the version cheat "-override-version 0.17"
  • Show the estimated score above the winrate bar

@featurecat
Copy link
Owner

featurecat commented Jun 22, 2019 via email

@kaorahi
Copy link
Contributor Author

kaorahi commented Jun 22, 2019

You only need to modify two lines in config.txt to use KataGo. No cmdline argument is required. Lizzie detects KataGo automatically through GTP.

"network-file": "katago-network.gz",
"engine-command": "./katago gtp -model %network-file -config gtp.cfg",

@Yakago
Copy link

Yakago commented Jun 24, 2019

I tried to compile with this change, and used @alreadydone 's windows compilation of KataGo (lightvector/KataGo#2)

I had an issue that lizzie would still use lz-analyze. I suspect that it is because it takes quite some time for the engine to load, and therefore respond with the proper 'name'. I'm not too sure as I'm a bit inexperienced will all this.

I just made some manual changes to force it to use kata-analyze and draw the score difference no matter what..

@kaorahi
Copy link
Contributor Author

kaorahi commented Jun 25, 2019

@Yakago, how about b320284?

Anyway, we may have another better implementation soon :)
lightvector/KataGo#25 (comment)

@Yakago
Copy link

Yakago commented Jun 25, 2019

I tried again with the new changes, and now I get it to start with kata-analyze

@zsalch
Copy link
Contributor

zsalch commented Jun 27, 2019

LGTM. Maybe it will be merged together #546 .

@zsalch zsalch merged commit 2814463 into featurecat:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants