Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade urllib3v2.2.2 #6426

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Upgrade urllib3v2.2.2 #6426

merged 1 commit into from
Aug 15, 2024

Conversation

tmpayton
Copy link
Contributor

Summary (required)

This ticket upgrades urllib3 to remove a security vulnerability.

Required reviewers 1 developer

Impacted areas of the application

General components of the application that this PR will affect:

  • server-side API calls

How to test

  • Check out this branch
  • activate your virtualenv
  • pip install -r requirements.txt
  • snyk test --file=requirements.txt --package-manager=pip (ensure urllib3 is not listed)
  • pytest
  • cd fec/
  • ./manage.py runserver
  • Test pages with server-side calls like the candidate or committee profile pages

You can also test by deploying this test branch to stage

Copy link
Contributor

@pkfec pkfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @tmpayton

Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks

@pkfec pkfec merged commit 71d7fb7 into develop Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Snyk: Med] Improper Handling of Insufficient Permissions or Privileges (Due 09/16/24)
3 participants