This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Glossary links #788
Merged
Glossary links #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay @noahmanger! Thanks for your great edits and patience. I think this is ready for your review (again). |
| @@ -1,4 +1,4 @@ | |||
| <option value="">Select district</option> | |||
| <option value="">Select <span class="term" data-term="District">district</span></option> | |||
There was a problem hiding this comment.
This is an option in the select, so shouldn't have a span.
|
Well the silver lining of you having to look at this a million times @noahmanger is that I'm learning a ton about HTML. Made your edits, and thank you. |
Conflicts: static/templates/committees.hbs static/templates/receipts.hbs templates/partials/committee/disbursements-tab.html
|
ping @noahmanger Anything I need to do? |
|
I don't think so...waiting for tests to pass. |
|
Awesome! Just wanted to make sure I didn't drop the ball somehow. :) |
Conflicts: templates/partials/committee/disbursements-tab.html templates/partials/committee/receipts-tab.html templates/search.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds glossary links
Addresses sentence-case capitalization issues
Resolves /issues/555#issuecomment-143491873