Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor](useTheme): singleton pattern #223

Merged
merged 2 commits into from
May 3, 2022

Conversation

nonzzz
Copy link
Collaborator

@nonzzz nonzzz commented Apr 26, 2022

Checklist


  • This is WIP now.
  • Use singleton pattern refactor useTheme hook.

Change information


In past, Each hook had its own instance. but refer to #222 . We found is unreasonable.

@nonzzz nonzzz added feature perf Make code stronger labels Apr 26, 2022
@nonzzz nonzzz self-assigned this Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #223 (dc13ec9) into master (533e3af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files         189      189           
  Lines        2126     2126           
  Branches      371      371           
=======================================
  Hits         2057     2057           
  Misses         69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533e3af...dc13ec9. Read the comment docs.

@nonzzz nonzzz merged commit bc31df3 into fect-org:master May 3, 2022
@nonzzz nonzzz deleted the feat/singalInstance branch May 3, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature perf Make code stronger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant