Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): modify modelValue can't trigger update #227

Merged
merged 1 commit into from
May 5, 2022

Conversation

nonzzz
Copy link
Collaborator

@nonzzz nonzzz commented May 5, 2022

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

In form component , we found when trigger update props modelValue can't update component internal value. so this pr will be fix them.


@nonzzz nonzzz added the bug Something isn't working label May 5, 2022
@nonzzz nonzzz requested a review from QiYuOr2 May 5, 2022 08:23
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #227 (a7abd46) into master (e3b546a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   96.75%   96.76%   +0.01%     
==========================================
  Files         189      189              
  Lines        2128     2136       +8     
  Branches      371      372       +1     
==========================================
+ Hits         2059     2067       +8     
  Misses         69       69              
Impacted Files Coverage Δ
packages/vue/src/checkbox-group/checkbox-group.tsx 100.00% <100.00%> (ø)
packages/vue/src/checkbox/checkbox.tsx 100.00% <100.00%> (ø)
packages/vue/src/radio-group/radio-group.tsx 100.00% <100.00%> (ø)
packages/vue/src/radio/radio.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b546a...a7abd46. Read the comment docs.

@nonzzz nonzzz merged commit 269514e into fect-org:master May 5, 2022
@nonzzz nonzzz deleted the fix/form branch May 5, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants