Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Select component multiple mode style err #248

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

nonzzz
Copy link
Collaborator

@nonzzz nonzzz commented Jul 13, 2022

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)
  • Rewrite select multiple logic.

Change information


@nonzzz nonzzz added the bug Something isn't working label Jul 13, 2022
@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for gorgeous-zuccutto-a10d51 ready!

Name Link
🔨 Latest commit 298cd14
🔍 Latest deploy log https://app.netlify.com/sites/gorgeous-zuccutto-a10d51/deploys/62ce43dd5a5eea0008318711
😎 Deploy Preview https://deploy-preview-248--gorgeous-zuccutto-a10d51.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #248 (298cd14) into master (3fbd78c) will decrease coverage by 0.07%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   92.17%   92.09%   -0.08%     
==========================================
  Files         195      195              
  Lines        2312     2315       +3     
  Branches      443      446       +3     
==========================================
+ Hits         2131     2132       +1     
- Misses        179      181       +2     
  Partials        2        2              
Impacted Files Coverage Δ
packages/vue/src/select/props.ts 100.00% <ø> (ø)
packages/vue/src/select-option/select-option.tsx 86.36% <40.00%> (-13.64%) ⬇️
packages/vue/src/select/select.tsx 95.00% <100.00%> (+0.94%) ⬆️

@nonzzz nonzzz merged commit 98ee08b into fect-org:master Jul 13, 2022
@nonzzz nonzzz deleted the fix/select branch July 13, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant